-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input-datepicker): disable invoker when readonly #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlouisse
changed the title
fix(input-datepicker): disable when invoker when readonly
[wip] fix(input-datepicker): disable when invoker when readonly
Jun 18, 2019
tlouisse
changed the title
[wip] fix(input-datepicker): disable when invoker when readonly
[wip] fix(input-datepicker): disable invoker when readonly
Jun 18, 2019
tlouisse
force-pushed
the
fix/readonlyDatepicker
branch
3 times, most recently
from
June 20, 2019 12:01
143768a
to
7d5f110
Compare
bashmish
suggested changes
Jun 20, 2019
tlouisse
changed the title
[wip] fix(input-datepicker): disable invoker when readonly
fix(input-datepicker): disable invoker when readonly
Jun 21, 2019
tlouisse
force-pushed
the
fix/readonlyDatepicker
branch
2 times, most recently
from
June 21, 2019 12:00
c23cc26
to
a2b3d70
Compare
bashmish
reviewed
Jun 21, 2019
bashmish
reviewed
Jun 21, 2019
bashmish
reviewed
Jun 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me now, let's just finalize last small bits on Monday 👍
tlouisse
force-pushed
the
fix/readonlyDatepicker
branch
from
June 24, 2019 07:43
a2b3d70
to
ada0184
Compare
bashmish
force-pushed
the
fix/readonlyDatepicker
branch
from
June 24, 2019 15:18
ada0184
to
0217494
Compare
bashmish
approved these changes
Jun 24, 2019
bashmish
force-pushed
the
fix/readonlyDatepicker
branch
from
June 24, 2019 15:21
0217494
to
5cd9452
Compare
fcarrascosa
pushed a commit
to fcarrascosa/lion
that referenced
this pull request
Nov 28, 2019
fix(input-datepicker): disable invoker when readonly
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92